Add createOptimisticAction helper that replaces useOptimisticMutation - #210
Merged
Conversation
🦋 Changeset detectedLatest commit: 5fff068 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@tanstack/db-example-react-todo commit: |
Contributor
|
Size Change: +317 B (+1.11%) Total Size: 29 kB
ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 822 B ℹ️ View Unchanged
|
samwillis
approved these changes
Jun 26, 2025
samwillis
left a comment
Collaborator
There was a problem hiding this comment.
Love it - so much cleaner ![]()
I was about to say we need to delete the useOptimisticQuery react and view tests... but we didn't have any 😂
Collaborator
Author
|
If you don't write any tests you don't have to delete them! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #202
An example of converting a
useOptimisticMutationhook tocreateOptimisticAction. Now all optimistic & server mutation logic are consolidated.